From 0083c60544e0e3ee4029aee48ff40be2057e6f3e Mon Sep 17 00:00:00 2001 From: 3DPrintingGeek <84936569+3DPrintingGeek@users.noreply.github.com> Date: Thu, 11 Apr 2024 10:19:45 +0200 Subject: [PATCH 1/2] fixes process not killed on remove When removing git-backup using the installer, there are still some processes left running in the background. To ensure a clean removal, and prevent problems on reinstallation, these processes should be killed on removal. --- scripts/git_backup.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/git_backup.sh b/scripts/git_backup.sh index cac28ca..5627133 100755 --- a/scripts/git_backup.sh +++ b/scripts/git_backup.sh @@ -60,6 +60,8 @@ function remove_git_backup(){ case "${yn}" in Y|y) echo -e "${white}" + echo -e "Info: Stopping processes..." + pkill git-backup.sh echo -e "Info: Removing files..." rm -f "$HS_CONFIG_FOLDER"/git-backup.cfg rm -f "INITD_FOLDER"/S52Git-Backup From 085d2350d48e0cf5adef135d6a8c387bfb7ab8a2 Mon Sep 17 00:00:00 2001 From: 3DPrintingGeek <84936569+3DPrintingGeek@users.noreply.github.com> Date: Thu, 11 Apr 2024 11:24:13 +0200 Subject: [PATCH 2/2] adds missing $ to INITD_FOLDER variable --- scripts/git_backup.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/git_backup.sh b/scripts/git_backup.sh index 5627133..0ea6ba7 100755 --- a/scripts/git_backup.sh +++ b/scripts/git_backup.sh @@ -64,7 +64,7 @@ function remove_git_backup(){ pkill git-backup.sh echo -e "Info: Removing files..." rm -f "$HS_CONFIG_FOLDER"/git-backup.cfg - rm -f "INITD_FOLDER"/S52Git-Backup + rm -f "$INITD_FOLDER"/S52Git-Backup rm -rf "$PRINTER_DATA_FOLDER"/.git if grep -q "include Helper-Script/git-backup" "$PRINTER_CFG" ; then echo -e "Info: Removing Git Backup configurations in printer.cfg file..."